[AiBundle] Improvements on configuration / tags #855
+2,161
−445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is this still needed? |
Contributor
Author
|
Yes, for message store's, some improvements to apply, need to finish it 🙂 |
Guikingone
force-pushed
the
fix/vector_store_config
branch
5 times, most recently
from
df07986 to
52d747a
Compare
Guikingone
changed the title
Guikingone
force-pushed
the
fix/vector_store_config
branch
from
52d747a to
d0ee93c
Compare
Guikingone
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
Contributor
|
That PR quite big, can you maybe split some logical parts to a dedicated PR? |
Contributor
Author
|
I can try to extract the Most of the added lines are tests, the heaviest file is |
OskarStark
added a commit
that referenced
this pull request
Nov 24, 2025
…one) This PR was merged into the main branch. Discussion ---------- [AI Bundle] Improvements on `lazy` / `proxy` usages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | Related to #855 | License | MIT Summary: * Add missing `lazy` to vector stores * Add `proxy` usage for vector stores (already used for message stores) * Sorting method calls on `Definition` usages (lazy, arguments, tags) * Remove a call to `Target::getParsedName()` (non compliant with recent discussions about injection aliases) Commits ------- 77e1ecc refactor(aibundle): improvements on configuration / tags
Guikingone
force-pushed
the
fix/vector_store_config
branch
from
d0ee93c to
685d084
Compare
Contributor
Author
|
@OskarStark FYI, I started to look at how to split this PR, the best approach would be to split it every two-three stores, this way, we should be able to easily merge smaller PRs, the final split is under work, should be ready pretty soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
options.phpandAiBundle.phpproxyadded for vector storeslazy